Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(RHTAPWATCH-1066): Unit tests for getWorkspacesWithAccess #50

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

hmariset
Copy link
Contributor

Add unit test for workspace-manager function
getWorkspacesWithAccess

Jira-Url: https://issues.redhat.com/browse/RHTAPWATCH-1066

@hmariset
Copy link
Contributor Author

@Omeramsc, @avi-biton Please review the PR.

cmd/main_test.go Outdated Show resolved Hide resolved
cmd/main_test.go Outdated Show resolved Hide resolved
cmd/main_test.go Outdated Show resolved Hide resolved
cmd/main_test.go Show resolved Hide resolved
Copy link
Collaborator

@Omeramsc Omeramsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, please add cleanup after the unit tests.

cmd/main_test.go Outdated Show resolved Hide resolved
cmd/main_test.go Outdated Show resolved Hide resolved
cmd/main_test.go Outdated Show resolved Hide resolved
cmd/main_test.go Outdated Show resolved Hide resolved
cmd/main_test.go Outdated Show resolved Hide resolved
cmd/main_test.go Show resolved Hide resolved
Copy link
Collaborator

@Omeramsc Omeramsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource managment between tests require fixing.

Also if my comments are not about typos/basic syntax, please comment on them with how you fixed them before resolving them (or wait for my resolution).

cmd/main_test.go Outdated Show resolved Hide resolved
Add unit test for workspace-manager function
getWorkspacesWithAccess

Jira-Url: https://issues.redhat.com/browse/RHTAPWATCH-1066
Signed-off-by: Homaja Marisetty <[email protected]>
Copy link
Collaborator

@Omeramsc Omeramsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Omeramsc Omeramsc merged commit 2273e5e into konflux-ci:main Aug 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants